argus fixes

[Carter Bullard]

Thanks David!!!!
   I'll incorporate these changes in "U" later today!
Carter

Carter Bullard
QoSient, LLC
300 E. 56th Street, Suite 18K
New York, New York  10022

carter at qosient.com
Phone +1 212 813-9426
Fax   +1 212 813-9426

> -----Original Message-----
> From: owner-argus at lists.andrew.cmu.edu
> [mailto:owner-argus at lists.andrew.cmu.edu]On Behalf Of David Brumley
> Sent: Wednesday, January 24, 2001 2:31 PM
> To: argus at lists.andrew.cmu.edu
> Subject: argus fixes
> 
> 
> 
> I've attached some minor fixes...
> 
> First, I've changed the sprintf() to snprintf() in argus_parse.c since
> this may be using environment variables and user-screwupable config
> files.  I didn't fix the other files as I'm not sure what the length
> of the buffers are......
> 
> 
> Also, fixed these warnings from -Wall in gencode.c:
> ./gencode.c:578: warning: `Argusgen_FarAttrtype' defined but not used
> ./gencode.c: In function `Argusgen_tcode':
> ./gencode.c:1168: warning: unused variable `alist'
> ./gencode.c:1167: warning: unused variable `addr'
> ./gencode.c:1167: warning: unused variable `mask'
> ./gencode.c:1166: warning: unused variable `eaddr'
> 
> Compiled for test with -pedantic, fixed a few of those warnings,
> esp. with regard to signededness of char strings (which may cause
> problems on AIX...had similar problems with ldap in the past).  I
> randomly chose to make everything unsigned char's, as the signedness
> was about half and half.
> 
> I did not fix the "ANSI C does not support" errors, cuz IMHO they're
> bogus.
> 
> Also, I tested argus's large file support on solaris.  Seems to work
> like a champ.  BTW, I found one bug in libpcap that may have bitten
> people in the past: they use int instead of ssize_t for some stat()'s
> in the various pcap-{dlpi,snoop,etc} files.  I submitted a bug report
> to tcpdump-workers at tcpdump.org but I got a lackluster response.
> 
> Next, I fixed a problem where the -S option segfaulted if the server
> wasn't in .rarc.  Specifically, in argus_parse.c around 1895
> addr->hostname = str; was causing the problem.  I added a malloc and
> strcpy() and everything seems to work now.  I think the problem was
> the addr->hostname pointer was referencing a string that no 
> longer existed.
> 
> Last, the longjump problem I was sporadically having in 1.8 for long
> filter expressions has gone away.  thanks carter :)
> 
> All diffs are on version T and made by:
> diff <newfile> <oldfile> 
> 
> cheers,
> david
> ---
> #+--+#+--+#+--+#+--+#+--+#+--+#+--+#+--+#+--+#+--+#+--+#+--+#+
> --+#+--+#
> David Brumley - Stanford Computer Security -   dbrumley at 
> Stanford.EDU
> Phone: +1-650-723-2445           WWW: 
http://www.stanford.edu/~dbrumley
Fax:   +1-650-725-9121  PGP: finger dbrumley-pgp at sunset.Stanford.EDU
#+--+#+--+#+--+#+--+#+--+#+--+#+--+#+--+#+--+#+--+#+--+#+--+#+--+#+--+#
Fact: you can burn 150 caloria per hour banging your head against a wall
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3699 bytes
Desc: not available
URL: <https://pairlist1.pair.net/pipermail/argus/attachments/20010124/94777771/attachment.bin>