argus-3.0.6.1 bug report

[David Edelman]

As far as I can tell argus-3.0.6.1 doesn't have any of the modules that you
mention. 

I suspect that you are actually looking at argus-clients-3.0.6.2. I suspect
that this is an error that should be fixed and it still exists (at a
different line number) in 3.0.7.14.

Carter is on vacation and I'm not sure when he is scheduled to return. I
have made the change to my copy of 3.0.7.14 and I am testing it.

--Dave



-----Original Message-----
From: argus-info-bounces+dedelman=iname.com at lists.andrew.cmu.edu
[mailto:argus-info-bounces+dedelman=iname.com at lists.andrew.cmu.edu] On
Behalf Of David Binderman
Sent: Monday, September 02, 2013 6:38 AM
To: argus-info at lists.andrew.cmu.edu
Subject: [ARGUS] argus-3.0.6.1 bug report

Hello there,

I just ran static analysis checker "cppcheck" over the
source code of argus-3.0.6.1

It said

[argus_client.c:2390] -> [argus_client.c:2398]: (warning) Variable 'pkts' is
reassigned a value before the old one has been used. 'break;' missing?
[argus_client.c:2391] -> [argus_client.c:2399]: (warning) Variable 'bytes'
is reassigned a value before the old one has been used. 'break;' missing?
[argus_client.c:2392] -> [argus_client.c:2400]: (warning) Variable
'appbytes' is reassigned a value before the old one has been used. 'break;'
missing?

Suggest add missing break.

It also said

[argus_client.c:11797]: (error) Resource leak: fd
[argus_label.c:339]: (error) Resource leak: fd
[argus_label.c:1800]: (error) Resource leak: fd
[radium.c:3048]: (error) Resource leak: ffd
[ranonymize.c:1882]: (error) Resource leak: fd

which might be worth fixing.

Regards

David Binderman 		 	   		  =
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 6283 bytes
Desc: not available
URL: <https://pairlist1.pair.net/pipermail/argus/attachments/20130902/e26ff5dd/attachment.bin>