new software on the server, ..., almost done

Peter Van Epp vanepp at sfu.ca
Sun Sep 9 22:25:14 EDT 2007


	Well that was a potentially useful exercise. OpenBSD seems to have 
shown up a nasty bug. We were allocating 5 bytes and using the pointer as a
128 byte time buffer likely causing all sorts of interesting problems as we 
overwrote other areas of the parser structure. Patch against 
argus-clients-3.0.0.rc.53.tar.gz below that fixes this (and keeps OpenBSD from 
complaining during shutdown too!). Now to see if that makes clients 53 happy 
with some of the data files it is currently sometimes unhappy about ...

Peter Van Epp / Operations and Technical Support 
Simon Fraser University, Burnaby, B.C. Canada

*** common/argus_parser.c.orig	Sun Sep  9 10:57:36 2007
--- common/argus_parser.c	Sun Sep  9 12:10:10 2007
***************
*** 76,82 ****
  
     retn->ArgusProgramName = strdup(progname);
     retn->ArgusCIDRPtr = &retn->ArgusCIDRBuffer;
!    retn->RaTimeFormat = "%T.%f";
     retn->RaClientTimeout.tv_sec = 1;
     retn->RaCloseInputFd = 1;
     retn->Oflag  = 1;
--- 76,85 ----
  
     retn->ArgusProgramName = strdup(progname);
     retn->ArgusCIDRPtr = &retn->ArgusCIDRBuffer;
!    retn->RaTimeFormat = (char *) malloc(128);
!    if (retn->RaTimeFormat == NULL)
!          ArgusLog(LOG_ERR, "ArgusNewParser: malloc %s", strerror(errno));
!    strncpy(retn->RaTimeFormat,"%T.%f",6);
     retn->RaClientTimeout.tv_sec = 1;
     retn->RaCloseInputFd = 1;
     retn->Oflag  = 1;



More information about the argus mailing list