patch for rrdtool-1.2.19

[Carter Bullard]

Gentle people,
So the word is that Tobi has fixed the legend spacing issues.  I looked
at the code and it should work, so we should be able to just take the  
"//J"
out of the legend COMMMENT: specifiers to the call to rrd_graph() in
ragraph.  Lets try this patch:

==== //depot/argus/clients/ragraph/ragraph.pl#9 - /home/carter/argus/ 
clients/ragraph/ragraph.pl ====
738c738
<                            $object = sprintf "%-2.2s%-*.*s \\J", "  
", $objwidth, $objwidth, $tobj;
---
 >                            $object = sprintf "%-2.2s%-*.*s ", " ",  
$objwidth, $objwidth, $tobj;
741c741
<                            $object = sprintf "%-4.4s%-*.*s \\J",  
"out ", $objwidth, $objwidth, $tobj;
---
 >                            $object = sprintf "%-4.4s%-*.*s ", "out  
", $objwidth, $objwidth, $tobj;
744c744
<                            $object = sprintf "%-4.4s%-*.*s \\J",  
"src ", $objwidth, $objwidth, $tobj;
---
 >                            $object = sprintf "%-4.4s%-*.*s ", "src  
", $objwidth, $objwidth, $tobj;

Carter


On May 3, 2007, at 2:43 AM, Robin Gruyters wrote:

>
> Robin Gruyters
> Network and Security Engineer
> Yirdis B.V.
> I: http://yirdis.com
> P: +31 (0)36 5300394
> F: +31 (0)36 5489119
>
>
>
> Hi Carter,
>
> Shouldn't this be \J? Because it is still not working for me.
>
> [...]
> ERROR: Unknown control code at the end of '  src *            \J'
> [...]
>
> Regards,
>
> Robin Gruyters
> Network and Security Engineer
> Yirdis B.V.
> I: http://yirdis.com
> P: +31 (0)36 5300394
> F: +31 (0)36 5489119
>
>
> Quoting Carter Bullard <carter at qosient.com>:
>
>> Gentle people,
>> With regard to ragraph() and the rrdtool /J option not being  
>> supported
>> in the latest rrd-tool distribution, here is the patch that can be  
>> applied to
>> the latest,  rrdtool-1.2.19.  Until I can get a dialogue going  
>> with the
>> rrd-developers, I'll provide these patches in the ragraph  
>> subdirectory
>> (once we're happy that they work).
>>
>> This modification allows us to get alignment of legend entries,  
>> without it
>> the legend can shift by a single character, if there are multiple  
>> lines
>> of entries,
>> which doesn't look very good.
>>
>> isis:~/Desktop/rrdtool-1.2.19/src$ diff rrd_graph.c rrd_graph.c.new
>> ------ Begin patch --------
>> 1412c1412
>> <     int   glue = 0;
>> ---
>>>     int   useglue = 1, glue = 0;
>> 1492a1493,1496
>>>         if (prt_fctn=='J') {
>>>            prt_fctn = '\0';
>>>            useglue = 0;
>>>         }
>> 1517c1521
>> <           if (leg_c >= 2 && prt_fctn == 'j') {
>> ---
>>>           if ((leg_c >= 2 && prt_fctn == 'j') && useglue) {
>>
>> ----- End patch --------
>>
>>
>> If there are any issues, please send mail to the list!!!
>>
>> Carter
>
>
> <mime-attachment>

Carter Bullard
CEO/President
QoSient, LLC
150 E. 57th Street Suite 12D
New York, New York 10022

+1 212 588-9133 Phone
+1 212 588-9134 Fax


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist1.pair.net/pipermail/argus/attachments/20070515/3bb79b4b/attachment.html>