rabins segfault

[Carter Bullard]

Hey Cedric,
    Seems like the right thing to do, just worried about portability.
I'll make the change, and also to all the other instances of
localtime (rasplit, ratop), and if the xxxBSD's barf, we'll try to  
figure
it out.

Thanks!!!!!!!

Carter


On Jun 22, 2006, at 5:23 AM, VIEAU Cédric 172196 wrote:

>> Hi,
>>
>> argus-3.0.0.rc.10 and argus-clients-3.0.0.rc.9 compile clean on  
>> Debian Etch "amd64" (kernel 2.6.15-1-em64t-p4-smp), thank you for  
>> the great work !
>>
>> However, I had a segfault with rabins using both v2 and v3 logs:
>>
>> (gdb)  run  -M zero -GL0 -s lasttime spkts dpkts dport -M 1m -r ../ 
>> argus/argus.log -D 9
>> ...
>> Program received signal SIGSEGV, Segmentation fault.
>> [Switching to Thread 46912502359760 (LWP 10029)]
>> 0x0000000000454d6c in ArgusAlignRecord (ns=0x2aaaaaac41a8,  
>> nadp=0x74ef20) at ./argus_client.c:4646
>> 4646             nadp->RaEndTmStruct = *localtime((time_t *) 
>> &endSecs);
>> (gdb) p/x localtime(&endSecs)
>> $1 = 0x0
>>
>> I replaced "localtime" with "localtime_r" in argus_client.c, and  
>> now the segfault is gone. I'm not sure if this is the right thing  
>> to do, so I submit this problem to your expert eyes !
>>
>> Patch and debug logs are attached to this mail. I can send you  
>> more info if you want.
>>
>> Cedric
>> <argus_client.c.patch>
>> <rabins_gdb.txt>
>
>