[ARGUS] [aj at andaco.de: Bug#285465: argus-client: FTBFS (amd64/gcc-4.0): static declaration of 'ArgusNetMask' follows non-static declaration]

[Andrew Pollock]

FYI.

I'm not sure how tested this patch is, given that Argus doesn't seem to be
too flash on 64-bit architectures at present. This patch presumably resolves
the build issues on AMD64, but I suspect it's not going to work properly
anyway.

I think I'll apply the patch to the Debian source anyway, but I'd appreciate
some comments on its general validity.

regards

Andrew

----- Forwarded message from Andreas Jochens <aj at andaco.de> -----

From: Andreas Jochens <aj at andaco.de>
To: Debian Bug Tracking System <submit at bugs.debian.org>
Subject: Bug#285465: argus-client: FTBFS (amd64/gcc-4.0): static declaration of 'ArgusNetMask' follows non-static declaration
Date: Mon, 13 Dec 2004 14:12:22 +0100

Package: argus-client
Severity: normal
Tags: patch

When building 'argus-client' on amd64 with gcc-4.0,
I get the following error:

gcc -O2 -I. -I../include  -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_STRING_H=1 -DHAVE_FCNTL_H=1 -DHAVE_SYS_FILE_H=1 -DHAVE_SYSLOG_H=1 -DHAVE_ETHER_HOSTTON=1 -DHAVE_STRERROR=1 -DSTDC_HEADERS=1  -c ./gencode.c
./gencode.c:235: error: static declaration of 'ArgusNetMask' follows non-static declaration
../include/argus_parse.h:1522: error: previous declaration of 'ArgusNetMask' was here
make[2]: *** [gencode.o] Error 1
make[2]: Leaving directory `/argus-client-2.0.6.fixes.1/common'

With the attached patch 'argus-client' can be compiled
on amd64 using gcc-4.0.

Regards
Andreas Jochens

diff -urN ../tmp-orig/argus-client-2.0.6.fixes.1/common/gencode.c ./common/gencode.c
--- ../tmp-orig/argus-client-2.0.6.fixes.1/common/gencode.c	2004-04-26 18:30:23.000000000 +0200
+++ ./common/gencode.c	2004-12-13 14:05:45.221992296 +0100
@@ -232,7 +232,7 @@
 #include <signal.h>
 #include <sys/wait.h>
 
-static u_int ArgusNetMask;
+u_int ArgusNetMask;
 static int snaplen;
 
 int


----- End forwarded message -----

-- 
linux.conf.au 2005   -  http://lca2005.linux.org.au/  -  Birthplace of Tux
April 18th to 23rd   -  http://lca2005.linux.org.au/  -       LINUX
Canberra, Australia  -  http://lca2005.linux.org.au/  -    Get bitten!